Skip to content

Conversation

@rpelke
Copy link
Contributor

@rpelke rpelke commented Oct 21, 2025

When TRITON_INTERPRET=1, the cache should always be disabled (in both cases, cache_results=true and TRITON_CACHE_AUTOTUNING=1). Otherwise, there is an error in check_disk_cache since it is searching for a JITFunction which is not available.
This has been discussed in #6678 already but the introduced changes still enable caching results when cache_results=true.

New contributor declaration

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test.
  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

When TRITON_INTERPRET=1, the cache should always be disabled in both
cases, cache_results=true and TRITON_CACHE_AUTOTUNING=1. Otherwise,
there is an error in `check_disk_cache` since it is searching for a
JITFunction which is not available.

Signed-off-by: Rebecca Pelke <[email protected]>
@rpelke rpelke requested a review from ptillet as a code owner October 21, 2025 09:43
@peterbell10 peterbell10 enabled auto-merge (squash) October 26, 2025 01:01
@peterbell10 peterbell10 merged commit e8bc90c into triton-lang:main Oct 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants